-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds note about two approval policy to PR template #10313
Conversation
Shoot! Should've added |
I think I wrote some stuff before around this https://github.com/babel/babel/wiki/Maintaining-Babel#merging but yeah the general case is 2, unless it's more of a typo thing (mostly for the website), I guess master is failing due to test fixtures (I assume related to data from compat type stuff) |
Because, although two approvals is the general case, some PRs maybe merged with more or fewer approvals
I wasn't aware of that documentation. Just added a qualifier to the proposal in light of that |
Should be fine to merge if master is ok |
I've sometimes noticed some folks getting confused about Babel's two approval policy. From the Contributor point of view, the PR seems stale after getting the first approval.
This adds a comment to the PR template with the goal of surfacing the policy and avoiding confusion.